dongjoon-hyun commented on code in PR #45715:
URL: https://github.com/apache/spark/pull/45715#discussion_r1538627313
##########
core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:
##########
@@ -401,16 +401,24 @@ private[spark] class SparkSubmit extends Logging {
// SPARK-33782 : This downloads all the files , jars , archiveFiles
and pyfiles to current
// working directory
// SPARK-43540: add current working directory into driver classpath
+ // SPARK-47475: make download to driver optional so executors may
fetch resource from remote
+ // url directly to avoid overwhelming driver network when resource is
big and executor count
+ // is high
val workingDirectory = "."
childClasspath += workingDirectory
- def downloadResourcesToCurrentDirectory(uris: String, isArchive:
Boolean = false):
+
+ def downloadResourcesToCurrentDirectory(uris: String,
+ isArchive: Boolean = false,
Review Comment:
Could you take a look at `Apache Spark Coding Guideline` at this time?
- https://spark.apache.org/contributing.html
> For Scala code, Apache Spark follows the official [Scala style
guide](http://docs.scala-lang.org/style/) and [Databricks Scala
guide](https://github.com/databricks/scala-style-guide). The latter is
preferred. To format Scala code, run ./dev/scalafmt prior to submitting a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
