cloud-fan commented on code in PR #45714:
URL: https://github.com/apache/spark/pull/45714#discussion_r1539219005
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/variant/variantExpressions.scala:
##########
@@ -40,7 +40,7 @@ import org.apache.spark.unsafe.types._
)
// scalastyle:on line.size.limit
case class ParseJson(child: Expression) extends UnaryExpression
- with NullIntolerant with ExpectsInputTypes with CodegenFallback {
+ with NullIntolerant with ExpectsInputTypes {
Review Comment:
For RuntimeReplaceable expression, the test should not evaluate it directly,
but evaluate its replacement. If the replacement is `StaticInvoke`, no
expression-level UT is needed (we should still test type coercion), and just
test the target java method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
