zhengruifeng commented on code in PR #45719: URL: https://github.com/apache/spark/pull/45719#discussion_r1540291098
########## python/pyspark/sql/connect/plan.py: ########## @@ -1120,53 +1126,48 @@ def plan(self, session: "SparkConnectClient") -> proto.Relation: class SQL(LogicalPlan): - def __init__(self, query: str, args: Optional[Union[Dict[str, Any], List]] = None) -> None: + def __init__( + self, + query: str, + args: Optional[List[Column]] = None, Review Comment: good point, I roughly remember that @HyukjinKwon recommended use `Sequence` insead of `List`. There are also other mix usage of `Mapping <-> Dict`, probably we can unify them in a separate PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
