GitHub user tdas opened a pull request:

    https://github.com/apache/spark/pull/708

    Converted bang to ask to avoid scary warning when a block is removed

    Removing a block through the blockmanager gave a scary warning messages in 
the driver. 
    ```
    2014-05-08 20:16:19,172 WARN BlockManagerMasterActor: Got unknown message: 
true
    2014-05-08 20:16:19,172 WARN BlockManagerMasterActor: Got unknown message: 
true
    2014-05-08 20:16:19,172 WARN BlockManagerMasterActor: Got unknown message: 
true
    ```
    
    This is because the 
[BlockManagerSlaveActor](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/storage/BlockManagerSlaveActor.scala#L44)
 would send back an acknowledgement ("true"). But the BlockManagerMasterActor 
would have sent the RemoveBlock message as a send, not as ask(), so would 
reject the receiver "true" as a unknown message. 
    @pwendell
    
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tdas/spark bm-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/708.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #708
    
----
commit ed4ef151c891825293f2fc596ce7361fc8e6ca3f
Author: Tathagata Das <[email protected]>
Date:   2014-05-09T03:11:59Z

    Converted bang to ask to avoid scary warning when a block is removed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to