dongjoon-hyun commented on code in PR #45740:
URL: https://github.com/apache/spark/pull/45740#discussion_r1542269102
##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -420,6 +420,10 @@ class SparkContext(config: SparkConf) extends Logging {
// HADOOP-19097 Set fs.s3a.connection.establish.timeout to 30s
// We can remove this after Apache Hadoop 3.4.1 releases
conf.setIfMissing("spark.hadoop.fs.s3a.connection.establish.timeout",
"30s")
+ // Enable Magic Committer by default for all S3 buckets if hadoop-cloud
module exists
+ if
(Utils.classIsLoadable("org.apache.spark.internal.io.cloud.PathOutputCommitProtocol"))
{
+
conf.setIfMissing("spark.hadoop.fs.s3a.bucket.*.committer.magic.enabled",
"true")
+ }
Review Comment:
Yes, at the first commit test on this PR, CI shows the following.
-
https://github.com/dongjoon-hyun/spark/actions/runs/8458713094/job/23173570901
```
[info] - SPARK-23731 plans should be canonicalizable after being
(de)serialized *** FAILED *** (53 milliseconds)
[info] java.lang.ClassNotFoundException:
org.apache.spark.internal.io.cloud.PathOutputCommitProtocol
[info] at
java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
[info] at
java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
[info] at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
[info] at java.base/java.lang.Class.forName0(Native Method)
[info] at java.base/java.lang.Class.forName(Class.java:467)
[info] at
org.apache.spark.util.SparkClassUtils.classForName(SparkClassUtils.scala:41)
[info] at
org.apache.spark.util.SparkClassUtils.classForName$(SparkClassUtils.scala:36)
[info] at org.apache.spark.util.Utils$.classForName(Utils.scala:97)
[info] at
org.apache.spark.internal.io.FileCommitProtocol$.instantiate(FileCommitProtocol.scala:213)
[info] at
org.apache.spark.sql.execution.datasources.InsertIntoHadoopFsRelationCommand.run(InsertIntoHadoopFsRelationCommand.scala:115)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
