LuciferYang commented on code in PR #45716:
URL: https://github.com/apache/spark/pull/45716#discussion_r1542666338
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/xml/CreateXmlParser.scala:
##########
@@ -75,13 +74,13 @@ object CreateXmlParser extends Serializable {
// a reader with specific encoding.
// The method creates a reader for an array with given encoding and sets
size of internal
// decoding buffer according to size of input array.
- private def getStreamDecoder(enc: String, in: Array[Byte], length: Int):
StreamDecoder = {
+ private def getStreamDecoder(enc: String, in: Array[Byte], length: Int):
Reader = {
val bais = new ByteArrayInputStream(in, 0, length)
val byteChannel = Channels.newChannel(bais)
val decodingBufferSize = Math.min(length, 8192)
val decoder = Charset.forName(enc).newDecoder()
- StreamDecoder.forDecoder(byteChannel, decoder, decodingBufferSize)
+ Channels.newReader(byteChannel, decoder, decodingBufferSize)
Review Comment:
for fix:
```
Error: ]
/home/runner/work/spark/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/xml/CreateXmlParser.scala:27:
object nio is not a member of package sun
Error: ]
/home/runner/work/spark/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/xml/CreateXmlParser.scala:78:
not found: type StreamDecoder
Error: ]
/home/runner/work/spark/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/xml/CreateXmlParser.scala:84:
not found: value StreamDecoder
Error: ]
/home/runner/work/spark/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/xml/CreateXmlParser.scala:27:
Unused import
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
