attilapiros commented on code in PR #45228:
URL: https://github.com/apache/spark/pull/45228#discussion_r1544106977
##########
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala:
##########
@@ -398,8 +410,13 @@ final class ShuffleBlockFetcherIterator(
var pushMergedLocalBlockBytes = 0L
val prevNumBlocksToFetch = numBlocksToFetch
- val fallback = FallbackStorage.FALLBACK_BLOCK_MANAGER_ID.executorId
- val localExecIds = Set(blockManager.blockManagerId.executorId, fallback)
+ // Fallback to original implementation, if thread pool is not enabled.
+ val localExecIds = if
(FallbackStorage.getNumReadThreads(blockManager.conf) > 0) {
Review Comment:
I found where it was first introduced:
https://github.com/apache/spark/pull/30492/files#r532833817
@dongjoon-hyun can an externally stored block ever be found locally?
If not I would prefer to see a separate case for the external blocks and
count them separately too.
So we would have the following block types:
- local
- host-local
- push-merged-local
- remote
- external
@maheshk114, @dongjoon-hyun WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
