dongjoon-hyun commented on code in PR #45779:
URL: https://github.com/apache/spark/pull/45779#discussion_r1544941904
##########
core/src/main/scala/org/apache/spark/MapOutputTracker.scala:
##########
@@ -725,11 +726,13 @@ private[spark] class MapOutputTrackerMaster(
// Make sure that we aren't going to exceed the max RPC message size by
making sure
// we use broadcast to send large map output statuses.
if (minSizeForBroadcast > maxRpcMessageSize) {
- val msg = s"${SHUFFLE_MAPOUTPUT_MIN_SIZE_FOR_BROADCAST.key}
($minSizeForBroadcast bytes) " +
- s"must be <= spark.rpc.message.maxSize ($maxRpcMessageSize bytes) to
prevent sending an " +
- "rpc message that is too large."
+ val msg = log"${MDC(CONFIG, SHUFFLE_MAPOUTPUT_MIN_SIZE_FOR_BROADCAST.key)}
" +
+ log"(${MDC(MIN_SIZE, minSizeForBroadcast.toString)} bytes) " +
+ log"must be <= spark.rpc.message.maxSize (${MDC(MAX_SIZE,
maxRpcMessageSize.toString)} " +
+ log"bytes) to prevent sending an rpc message that is too large."
+
logError(msg)
- throw new IllegalArgumentException(msg)
+ throw new IllegalArgumentException(msg.message)
Review Comment:
This seems to be touched as the example. Shall we revert this?
##########
core/src/main/scala/org/apache/spark/MapOutputTracker.scala:
##########
@@ -725,11 +726,13 @@ private[spark] class MapOutputTrackerMaster(
// Make sure that we aren't going to exceed the max RPC message size by
making sure
// we use broadcast to send large map output statuses.
if (minSizeForBroadcast > maxRpcMessageSize) {
- val msg = s"${SHUFFLE_MAPOUTPUT_MIN_SIZE_FOR_BROADCAST.key}
($minSizeForBroadcast bytes) " +
- s"must be <= spark.rpc.message.maxSize ($maxRpcMessageSize bytes) to
prevent sending an " +
- "rpc message that is too large."
+ val msg = log"${MDC(CONFIG, SHUFFLE_MAPOUTPUT_MIN_SIZE_FOR_BROADCAST.key)}
" +
+ log"(${MDC(MIN_SIZE, minSizeForBroadcast.toString)} bytes) " +
+ log"must be <= spark.rpc.message.maxSize (${MDC(MAX_SIZE,
maxRpcMessageSize.toString)} " +
+ log"bytes) to prevent sending an rpc message that is too large."
+
logError(msg)
- throw new IllegalArgumentException(msg)
+ throw new IllegalArgumentException(msg.message)
Review Comment:
This seems to be touched as the example. Shall we revert this file's change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
