panbingkun commented on code in PR #45776:
URL: https://github.com/apache/spark/pull/45776#discussion_r1545539985
##########
sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameWriterV2Suite.java:
##########
@@ -26,29 +32,30 @@
import org.apache.spark.sql.connector.catalog.InMemoryTableCatalog;
import org.apache.spark.sql.test.TestSparkSession;
import org.apache.spark.sql.types.StructType;
-import org.junit.jupiter.api.AfterEach;
-import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Test;
+import org.apache.spark.util.Utils;
import static org.apache.spark.sql.functions.*;
public class JavaDataFrameWriterV2Suite {
private static StructType schema = new StructType().add("s", "string");
private SparkSession spark = null;
+ private transient String input;
Review Comment:
After careful consideration, I think it would be more appropriate to call it
`input` here, as it could be `a specific file` or `a directory`. Therefore, to
be compatible with `the meaning` here, it seems more reasonable to call it
`input` ( or "inputDir" ?),
Additionally, because it corresponds to another test class
`JavaDataFrameReaderWriterSuite`, as follows:
https://github.com/apache/spark/blob/11d76c96554cc71c6a941c99222c08c76bd04bf2/sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameReaderWriterSuite.java#L35-L36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
