uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1546511420
########## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ########## @@ -549,6 +549,45 @@ public int findInSet(UTF8String match) { return 0; } + public int findInSet(UTF8String match, int collationId) { + if (CollationFactory.fetchCollation(collationId).supportsBinaryEquality) { + return this.findInSet(match); + } + if (collationId == CollationFactory.UTF8_BINARY_LCASE_COLLATION_ID) { + return this.toLowerCase().findInSet(match.toLowerCase()); + } + return collatedFindInSet(match, collationId); +} + + private int collatedFindInSet(UTF8String match, int collationId) { Review Comment: Let's go with this naming: `collationAwareFindInSet` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org