attilapiros commented on PR #45801: URL: https://github.com/apache/spark/pull/45801#issuecomment-2030972406
Hi @dongjoon-hyun, Thanks! I am fine either way. By the way should not we need to extend the condition with `|| version == "4.0"` here: https://github.com/apache/spark/blob/f3f1ee3b481ef2419922eb296116ae583ad9e8c8/sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveClientSuite.scala#L166 The rest looks good to me but we should wait for the tests to finish. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
