panbingkun commented on code in PR #45808:
URL: https://github.com/apache/spark/pull/45808#discussion_r1547090080
##########
common/utils/src/test/scala/org/apache/spark/util/StructuredLoggingSuite.scala:
##########
@@ -57,12 +58,14 @@ trait LoggingSuiteBase
def msgWithMDCAndException: LogEntry = log"Error in executor
${MDC(EXECUTOR_ID, "1")}."
- def expectedPatternForBasicMsg(level: Level): String
-
def msgWithConcat: LogEntry = log"Min Size: ${MDC(MIN_SIZE, "2")}, " +
log"Max Size: ${MDC(MAX_SIZE, "4")}. " +
log"Please double check."
+ def expectedPatternForBasicMsg(level: Level): String
Review Comment:
Add a new test for `basicMsg` + `Exception`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
