LuciferYang commented on code in PR #45812:
URL: https://github.com/apache/spark/pull/45812#discussion_r1547191432
##########
sql/core/src/test/scala/org/apache/spark/sql/JoinHintSuite.scala:
##########
@@ -695,11 +695,11 @@ class JoinHintSuite extends PlanTest with
SharedSparkSession with AdaptiveSparkP
val hintAppender = new LogAppender(s"join hint check for equi-join")
withLogAppender(hintAppender, level = Some(Level.WARN)) {
assertBroadcastNLJoin(
- df1.hint("SHUFFLE_HASH").join(df2, $"a1" !== $"b1"), BuildRight)
+ df1.hint("SHUFFLE_HASH").join(df2, $"a1"=!= $"b1"), BuildRight)
}
withLogAppender(hintAppender, level = Some(Level.WARN)) {
assertBroadcastNLJoin(
- df1.join(df2.hint("MERGE"), $"a1" !== $"b1"), BuildRight)
+ df1.join(df2.hint("MERGE"), $"a1" =!= $"b1"), BuildRight)
Review Comment:
Yes, other calls are in the DeprecatedAPISuite, we should keep them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
