uros-db commented on code in PR #45725:
URL: https://github.com/apache/spark/pull/45725#discussion_r1546515387


##########
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##########
@@ -913,6 +1028,50 @@ public UTF8String subStringIndex(UTF8String delim, int 
count) {
     }
   }
 
+  public UTF8String collatedSubStringIndex(UTF8String delim, int count, int 
collationId) {

Review Comment:
   Let's go with this naming: `collationAwareSubStringIndex` for these private 
functions that take a collationId
   
   ref: https://github.com/apache/spark/pull/45749#discussion_r1546421174



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to