stefankandic commented on code in PR #45820:
URL: https://github.com/apache/spark/pull/45820#discussion_r1548100850


##########
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala:
##########
@@ -73,6 +74,57 @@ class CollationStringExpressionsSuite extends QueryTest
     })
   }
 
+  test("TRANSLATE check result on explicitly collated string") {
+    def testTranslate(input: String,

Review Comment:
   this should probably be just a private method, no need to wrap it inside a 
test since the the test wouldn't be testing anything



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to