dongjoon-hyun commented on code in PR #45823:
URL: https://github.com/apache/spark/pull/45823#discussion_r1548383109
##########
scalastyle-config.xml:
##########
@@ -150,6 +150,11 @@ This file is divided into 3 sections:
// scalastyle:on println]]></customMessage>
</check>
+ <check customId="invalidMDC" level="error"
class="org.scalastyle.file.RegexChecker" enabled="true">
+ <parameters><parameter name="regex">s".*MDC</parameter></parameters>
Review Comment:
This regex looks too broad to me. For example, this will block the
following, right?
```
s"text and no MDC from Spark will print $msg"
```
```
case e: NoSuchFieldError => logInfo(s"MDC is not supported due to $e.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
