HyukjinKwon commented on code in PR #45816:
URL: https://github.com/apache/spark/pull/45816#discussion_r1548780039
##########
common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java:
##########
@@ -107,6 +107,28 @@ public void binaryCompareTo() {
assertTrue(fromString("你好123").binaryCompare(fromString("你好122")) > 0);
}
+ @Test
+ public void lowercaseComparison() {
+ // ASCII
Review Comment:
Should be:
```
public void testCase() {
// SPARK-12345: a short description of the test
...
```
See https://spark.apache.org/contributing.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
