zhengruifeng commented on code in PR #45614:
URL: https://github.com/apache/spark/pull/45614#discussion_r1548784881


##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -131,6 +132,23 @@ message SQL {
   repeated Expression pos_arguments = 5;
 }
 
+// Relation of type [[WithRelations]].
+//
+// This relation contains a root plan, and one or more references that are 
used by the root plan.
+// There are two ways of referencing a relation, by name (through a subquery 
alias), or by plan_id
+// (using RelationCommon.plan_id).
+//
+// This relation can be used to implement CTEs, describe DAGs, or to reduce 
tree depth.
+message WithRelations {

Review Comment:
   @hvanhovell would you mind help review this one? thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to