gengliangwang commented on PR #45813: URL: https://github.com/apache/spark/pull/45813#issuecomment-2033407009
> Do we need to support the second(Sting + MDC) and third(MDC + Sting) methods besides the first one? So by the end of this project, all the log entries containing variables will use `logError(log"...")`. `logError(s"...")` will not be allowed. I am not sure about how easy to build such scala style check if we allow `log"..." + str `. If it is complicated, we can stay with MDC concat only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
