pan3793 commented on code in PR #45808:
URL: https://github.com/apache/spark/pull/45808#discussion_r1548950710
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala:
##########
@@ -532,7 +533,8 @@ class ExecutorPodsAllocator(
currentTime - creationTime > executorIdleTimeout
} catch {
case e: Exception =>
- logError(s"Cannot get the creationTimestamp of the pod: ${state.pod}",
e)
+ logError(log"Cannot get the creationTimestamp of the pod: " +
+ log"${MDC(LogKey.POD_ID, state.pod)}", e)
Review Comment:
IMO `POD_ID` is not a suitable key here. `state.pod` actually outputs a
whole Pod Spec, and there is no such a "pod id" concept in the K8s, in
practice, we use `namespace` and `pod name` to identify a pod.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
