panbingkun commented on code in PR #45837:
URL: https://github.com/apache/spark/pull/45837#discussion_r1549078089
##########
common/utils/src/main/scala/org/apache/spark/internal/Logging.scala:
##########
@@ -117,7 +119,7 @@ trait Logging {
}
}
- private def withLogContext(context: java.util.HashMap[String, String])(body:
=> Unit): Unit = {
+ protected def withLogContext(context: java.util.HashMap[String,
String])(body: => Unit): Unit = {
Review Comment:
Why change `private` to `protected`
because some class extends `Logging` and override the method `logInfo`,
`logWarn`, 'logError', eg:
mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation.scala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
