yaooqinn commented on code in PR #45835:
URL: https://github.com/apache/spark/pull/45835#discussion_r1549227646
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala:
##########
@@ -110,8 +110,9 @@ private case class MySQLDialect() extends JdbcDialect with
SQLConfHelper {
case Types.VARCHAR if "TINYTEXT".equalsIgnoreCase(typeName) =>
// TINYTEXT is Types.VARCHAR(63) from mysql jdbc, but keep it AS-IS
for historical reason
Some(StringType)
- case Types.VARCHAR if "JSON".equalsIgnoreCase(typeName) =>
- // Some MySQL JDBC drivers converts JSON type into Types.VARCHAR with
a precision of -1.
+ case Types.VARCHAR | Types.CHAR if "JSON".equalsIgnoreCase(typeName) =>
+ // Some MySQL JDBC drivers converts JSON type into Types.VARCHAR with
a precision of -1
Review Comment:
Please improve the comment here with
- MySQL Connector/J 5.x as an example
- the link
https://github.com/mysql/mysql-connector-j/blob/release/5.1/src/com/mysql/jdbc/MysqlDefs.java#L295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
