LuciferYang commented on PR #45838:
URL: https://github.com/apache/spark/pull/45838#issuecomment-2034076896

   I get errors when I manually run the mima check. Could you please update the 
`MimaExcludes`?
   
   ```
   [error] spark-sql-api: Failed binary compatibility check against 
org.apache.spark:spark-sql-api_2.13:3.5.0! Found 1 potential problems (filtered 
170)
   [error]  * method unapplySeq(org.json4s.JsonAST#JValue)scala.Option in 
object org.apache.spark.sql.types.DataType#JSortedObject's type is different in 
current version, where it is (org.json4s.JValue)scala.Option instead of 
(org.json4s.JsonAST#JValue)scala.Option
   [error]    filter with: 
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.sql.types.DataType#JSortedObject.unapplySeq")
   
   [error] spark-sql: Failed binary compatibility check against 
org.apache.spark:spark-sql_2.13:3.5.0! Found 1 potential problems (filtered 861)
   [error]  * method jsonValue()org.json4s.JsonAST#JValue in class 
org.apache.spark.sql.expressions.MutableAggregationBuffer has a different 
result type in current version, where it is org.json4s.JValue rather than 
org.json4s.JsonAST#JValue
   [error]    filter with: 
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.sql.expressions.MutableAggregationBuffer.jsonValue")
   
   [error] spark-mllib: Failed binary compatibility check against 
org.apache.spark:spark-mllib_2.13:3.5.0! Found 11 potential problems (filtered 
477)
   [error]  * method params()org.json4s.JsonAST#JValue in class 
org.apache.spark.ml.util.DefaultParamsReader#Metadata has a different result 
type in current version, where it is org.json4s.JValue rather than 
org.json4s.JsonAST#JValue
   [error]    filter with: 
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.ml.util.DefaultParamsReader#Metadata.params")
   [error]  * method defaultParams()org.json4s.JsonAST#JValue in class 
org.apache.spark.ml.util.DefaultParamsReader#Metadata has a different result 
type in current version, where it is org.json4s.JValue rather than 
org.json4s.JsonAST#JValue
   [error]    filter with: 
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.ml.util.DefaultParamsReader#Metadata.defaultParams")
   [error]  * method metadata()org.json4s.JsonAST#JValue in class 
org.apache.spark.ml.util.DefaultParamsReader#Metadata has a different result 
type in current version, where it is org.json4s.JValue rather than 
org.json4s.JsonAST#JValue
   [error]    filter with: 
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.ml.util.DefaultParamsReader#Metadata.metadata")
   [error]  * method getParamValue(java.lang.String)org.json4s.JsonAST#JValue 
in class org.apache.spark.ml.util.DefaultParamsReader#Metadata has a different 
result type in current version, where it is org.json4s.JValue rather than 
org.json4s.JsonAST#JValue
   [error]    filter with: 
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.ml.util.DefaultParamsReader#Metadata.getParamValue")
   [error]  * method 
copy(java.lang.String,java.lang.String,Long,java.lang.String,org.json4s.JsonAST#JValue,org.json4s.JsonAST#JValue,org.json4s.JsonAST#JValue,java.lang.String)org.apache.spark.ml.util.DefaultParamsReader#Metadata
 in class org.apache.spark.ml.util.DefaultParamsReader#Metadata's type is 
different in current version, where it is 
(java.lang.String,java.lang.String,Long,java.lang.String,org.json4s.JValue,org.json4s.JValue,org.json4s.JValue,java.lang.String)org.apache.spark.ml.util.DefaultParamsReader#Metadata
 instead of 
(java.lang.String,java.lang.String,Long,java.lang.String,org.json4s.JsonAST#JValue,org.json4s.JsonAST#JValue,org.json4s.JsonAST#JValue,java.lang.String)org.apache.spark.ml.util.DefaultParamsReader#Metadata
   [error]    filter with: 
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.ml.util.DefaultParamsReader#Metadata.copy")
   [error]  * synthetic method copy$default$5()org.json4s.JsonAST#JValue in 
class org.apache.spark.ml.util.DefaultParamsReader#Metadata has a different 
result type in current version, where it is org.json4s.JValue rather than 
org.json4s.JsonAST#JValue
   [error]    filter with: 
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.ml.util.DefaultParamsReader#Metadata.copy$default$5")
   [error]  * synthetic method copy$default$6()org.json4s.JsonAST#JValue in 
class org.apache.spark.ml.util.DefaultParamsReader#Metadata has a different 
result type in current version, where it is org.json4s.JValue rather than 
org.json4s.JsonAST#JValue
   [error]    filter with: 
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.ml.util.DefaultParamsReader#Metadata.copy$default$6")
   [error]  * synthetic method copy$default$7()org.json4s.JsonAST#JValue in 
class org.apache.spark.ml.util.DefaultParamsReader#Metadata has a different 
result type in current version, where it is org.json4s.JValue rather than 
org.json4s.JsonAST#JValue
   [error]    filter with: 
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.ml.util.DefaultParamsReader#Metadata.copy$default$7")
   [error]  * method 
this(java.lang.String,java.lang.String,Long,java.lang.String,org.json4s.JsonAST#JValue,org.json4s.JsonAST#JValue,org.json4s.JsonAST#JValue,java.lang.String)Unit
 in class org.apache.spark.ml.util.DefaultParamsReader#Metadata's type is 
different in current version, where it is 
(java.lang.String,java.lang.String,Long,java.lang.String,org.json4s.JValue,org.json4s.JValue,org.json4s.JValue,java.lang.String)Unit
 instead of 
(java.lang.String,java.lang.String,Long,java.lang.String,org.json4s.JsonAST#JValue,org.json4s.JsonAST#JValue,org.json4s.JsonAST#JValue,java.lang.String)Unit
   [error]    filter with: 
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.ml.util.DefaultParamsReader#Metadata.this")
   [error]  * method 
apply(java.lang.String,java.lang.String,Long,java.lang.String,org.json4s.JsonAST#JValue,org.json4s.JsonAST#JValue,org.json4s.JsonAST#JValue,java.lang.String)org.apache.spark.ml.util.DefaultParamsReader#Metadata
 in object org.apache.spark.ml.util.DefaultParamsReader#Metadata in current 
version does not have a correspondent with same parameter signature among 
(java.lang.String,java.lang.String,Long,java.lang.String,org.json4s.JValue,org.json4s.JValue,org.json4s.JValue,java.lang.String)org.apache.spark.ml.util.DefaultParamsReader#Metadata,
 
(java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object,java.lang.Object)java.lang.Object
   [error]    filter with: 
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.ml.util.DefaultParamsReader#Metadata.apply")
   [error]  * method 
readMetadata(org.json4s.JsonAST#JValue)org.apache.spark.mllib.tree.model.TreeEnsembleModel#SaveLoadV1_0#Metadata
 in object org.apache.spark.mllib.tree.model.TreeEnsembleModel#SaveLoadV1_0's 
type is different in current version, where it is 
(org.json4s.JValue)org.apache.spark.mllib.tree.model.TreeEnsembleModel#SaveLoadV1_0#Metadata
 instead of 
(org.json4s.JsonAST#JValue)org.apache.spark.mllib.tree.model.TreeEnsembleModel#SaveLoadV1_0#Metadata
   [error]    filter with: 
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.mllib.tree.model.TreeEnsembleModel#SaveLoadV1_0.readMetadata")
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to