uros-db commented on code in PR #45738:
URL: https://github.com/apache/spark/pull/45738#discussion_r1549911287
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala:
##########
@@ -86,6 +89,43 @@ class CollationStringExpressionsSuite extends QueryTest
testRepeat("UNICODE_CI", 3, "abc", 2)
}
+ test("substring check output type on explicitly collated string") {
Review Comment:
try covering some more edge cases in these tests, such as: empty strings,
uppercase and lowercase mix, different byte-length chars, etc.
good example would be this PR: https://github.com/apache/spark/pull/45749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
