uros-db commented on code in PR #45856:
URL: https://github.com/apache/spark/pull/45856#discussion_r1550943142
##########
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##########
@@ -1095,21 +1103,30 @@ public UTF8String[] splitSQL(UTF8String delimiter, int
limit) {
}
}
- private UTF8String[] split(String delimiter, int limit) {
+ private UTF8String[] split(String delimiter, int limit, int regexFlags) {
// Java String's split method supports "ignore empty string" behavior when
the limit is 0
// whereas other languages do not. To avoid this java specific behavior,
we fall back to
// -1 when the limit is 0.
if (limit == 0) {
limit = -1;
}
- String[] splits = toString().split(delimiter, limit);
+ String[] splits;
+ if (regexFlags == 0) {
Review Comment:
(see comment above)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
