cloud-fan commented on code in PR #45488:
URL: https://github.com/apache/spark/pull/45488#discussion_r1550953116
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala:
##########
@@ -369,6 +373,23 @@ class QueryExecution(
Utils.redact(sparkSession.sessionState.conf.stringRedactionPattern,
message)
}
+ def extendedExplainInfo(append: String => Unit, plan: SparkPlan): Unit = {
+ val generators =
sparkSession.sessionState.conf.getConf(SQLConf.EXTENDED_EXPLAIN_PROVIDERS)
+ .getOrElse(Seq.empty)
+ val extensions = Utils.loadExtensions(classOf[ExtendedExplainGenerator],
+ generators,
+ sparkSession.sparkContext.conf)
+ if (extensions.nonEmpty) {
+ append("\n== Extended Information ==\n")
Review Comment:
Since we support more than one `ExtendedExplainGenerator`, shall we add a
new method `def title: String` in the trait and included in here like `==
Extended Information ($title) ==`?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala:
##########
@@ -369,6 +373,23 @@ class QueryExecution(
Utils.redact(sparkSession.sessionState.conf.stringRedactionPattern,
message)
}
+ def extendedExplainInfo(append: String => Unit, plan: SparkPlan): Unit = {
+ val generators =
sparkSession.sessionState.conf.getConf(SQLConf.EXTENDED_EXPLAIN_PROVIDERS)
+ .getOrElse(Seq.empty)
+ val extensions = Utils.loadExtensions(classOf[ExtendedExplainGenerator],
+ generators,
+ sparkSession.sparkContext.conf)
+ if (extensions.nonEmpty) {
+ append("\n== Extended Information ==\n")
Review Comment:
Since we support more than one `ExtendedExplainGenerator`, shall we add a
new method `def title: String` in the trait and included it here like `==
Extended Information ($title) ==`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
