stefankandic commented on code in PR #45782:
URL: https://github.com/apache/spark/pull/45782#discussion_r1551416602
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PruneFileSourcePartitions.scala:
##########
@@ -63,8 +63,7 @@ private[sql] object PruneFileSourcePartitions extends
Rule[LogicalPlan] {
_))
if filters.nonEmpty && fsRelation.partitionSchema.nonEmpty =>
val normalizedFilters = DataSourceStrategy.normalizeExprs(
- filters.filter(f =>
- !SubqueryExpression.hasSubquery(f) &&
DataSourceUtils.shouldPushFilter(f)),
+ filters.filter(f => f.deterministic &&
!SubqueryExpression.hasSubquery(f)),
Review Comment:
yes, you are correct, i thought that this would only be called for partition
key filters but i see now that it is not the case - fixed it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
