dongjoon-hyun commented on code in PR #45880: URL: https://github.com/apache/spark/pull/45880#discussion_r1552058097
########## python/pyspark/resource/tests/test_connect_resources.py: ########## @@ -18,10 +18,13 @@ from pyspark.resource import ResourceProfileBuilder, TaskResourceRequests, ExecutorResourceRequests from pyspark.sql import SparkSession -from pyspark.testing.sqlutils import have_pandas, pandas_requirement_message +from pyspark.testing.connectutils import ( + should_test_connect, + connect_requirement_message, +) [email protected](not have_pandas, pandas_requirement_message) [email protected](not should_test_connect, connect_requirement_message) Review Comment: `should_test_connect` covers more edge cases than `have_pandas`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
