dongjoon-hyun commented on code in PR #45425:
URL: https://github.com/apache/spark/pull/45425#discussion_r1552133989
##########
common/network-common/src/test/java/org/apache/spark/network/crypto/AuthEngineSuite.java:
##########
@@ -48,15 +50,19 @@ public class AuthEngineSuite {
"fb00000005617070496400000010708451c9dd2792c97c1ca66e6df449ef0000003c64fe899ecdaf458d4"
+
"e25e9d5c5a380b8e6d1a184692fac065ed84f8592c18e9629f9c636809dca2ffc041f20346eb53db78738"
+
"08ecad08b46b5ee3ff";
- private static final String sharedKey =
- "31963f15a320d5c90333f7ecf5cf3a31c7eaf151de07fef8494663a9f47cfd31";
+ private static final String derivedKey = "2d6e7a9048c8265c33a8f3747bfcc84c";
+ // This key would have been derived from an older version of the protocol
that did not run a final HKDF pass
+ private static final String unsafeDerivedKey =
"31963f15a320d5c90333f7ecf5cf3a31c7eaf151de07fef8494663a9f47cfd31";
+
private static final String inputIv = "fc6a5dc8b90a9dad8f54f08b51a59ed2";
private static final String outputIv = "a72709baf00785cad6329ce09f631f71";
private static TransportConf conf;
@BeforeAll
public static void setUp() {
- conf = new TransportConf("rpc", MapConfigProvider.EMPTY);
+ ConfigProvider v2Provider = new MapConfigProvider(Collections.singletonMap(
+ "spark.network.crypto.authEngineVersion", "2"));
Review Comment:
I'm wondering if this means that we don't test `v1` from now.
We had better keep the test coverage for v1 in addition to v2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
