srielau commented on code in PR #45859: URL: https://github.com/apache/spark/pull/45859#discussion_r1552142241
########## sql/core/src/test/resources/sql-tests/inputs/datetime-formatting-exception.sql: ########## @@ -0,0 +1,2 @@ +--SET spark.sql.legacy.timeParserPolicy=EXCEPTION +--IMPORT datetime-formatting.sql Review Comment: I'm puzzling about this as well. I cannot find where we explicitly tested CORRECTED before, although EXCEPTION was the default. I expected copy the existing tests, label them EXCEPTION and it should behave as before. And the existing files, with the new default should have no/fewer exceptions. This is not what I observe... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
