gengliangwang commented on PR #45729:
URL: https://github.com/apache/spark/pull/45729#issuecomment-2038127812

   > Seems it does not get implemented in this PR, in the migration PRs, we 
still inject the Spark identifiers like APP_ID manually in each message. 
   
   This will be done. 
   The current migration is necessary, for example, there are logs about 
executor/worker on driver. 
   
   
   > Another question is, as we use the enum LogKey to track all known MDC 
keys, is it possible to inject custom keys?
   
   It is possible, developers can either use ThreadContext from Log4j, or 
create a customized MessageWithContext entry
   ```
   case class MessageWithContext(message: String, context: 
java.util.HashMap[String, String])
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to