gengliangwang commented on code in PR #45866:
URL: https://github.com/apache/spark/pull/45866#discussion_r1552555429
##########
common/utils/src/main/scala/org/apache/spark/internal/Logging.scala:
##########
@@ -127,95 +141,60 @@ trait Logging {
}
// Log methods that take only a String
- protected def logInfo(msg: => String): Unit = {
- if (log.isInfoEnabled) log.info(msg)
- }
-
- protected def logInfo(entry: LogEntry): Unit = {
- if (log.isInfoEnabled) {
- withLogContext(entry.context) {
- log.info(entry.message)
- }
- }
- }
-
- protected def logInfo(entry: LogEntry, throwable: Throwable): Unit = {
- if (log.isInfoEnabled) {
- withLogContext(entry.context) {
- log.info(entry.message, throwable)
- }
- }
- }
-
- protected def logDebug(msg: => String): Unit = {
- if (log.isDebugEnabled) log.debug(msg)
- }
-
- protected def logTrace(msg: => String): Unit = {
- if (log.isTraceEnabled) log.trace(msg)
- }
-
- protected def logWarning(msg: => String): Unit = {
- if (log.isWarnEnabled) log.warn(msg)
- }
-
- protected def logWarning(entry: LogEntry): Unit = {
- if (log.isWarnEnabled) {
- withLogContext(entry.context) {
- log.warn(entry.message)
- }
- }
- }
-
- protected def logWarning(entry: LogEntry, throwable: Throwable): Unit = {
- if (log.isWarnEnabled) {
- withLogContext(entry.context) {
- log.warn(entry.message, throwable)
- }
- }
- }
-
- protected def logError(msg: => String): Unit = {
- if (log.isErrorEnabled) log.error(msg)
- }
+ protected def logDebug(msg: => String): Unit = if (log.isDebugEnabled)
log.debug(msg)
Review Comment:
Shall we keep the rest of the file unchanged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
