jiangzho commented on code in PR #2: URL: https://github.com/apache/spark-kubernetes-operator/pull/2#discussion_r1552627780
########## build-tools/helm/spark-kubernetes-operator/crds/sparkapplications.org.apache.spark-v1.yml: ########## @@ -0,0 +1,6947 @@ +# Generated by Fabric8 CRDGenerator, manual edits might get overwritten! Review Comment: Yes, this can be achieved. It's added for * reference * packed & used by the helm chart But this is not mandatory. We already have a gradle task to automatically generate this at compile time. If it's more preferred to not have the generated yaml checked in, I can remove it when implementing the chart publishing to helm reporistory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
