dongjoon-hyun commented on code in PR #45873:
URL: https://github.com/apache/spark/pull/45873#discussion_r1553811587


##########
python/pyspark/conf.py:
##########
@@ -60,11 +62,11 @@ class SparkConf:
 
     Examples
     --------
-    >>> from pyspark.core.conf import SparkConf
-    >>> from pyspark.core.context import SparkContext
+    >>> from pyspark.conf import SparkConf
+    >>> from pyspark.context import SparkContext

Review Comment:
   The PR title doesn't mention `SparkContext` change at all. Could you proceed 
`SparkContext` change as a separate PR at least please, @HyukjinKwon ?
   ```
   Make SparkConf to root level to for both SparkSession and SparkContext
   ```



##########
python/pyspark/conf.py:
##########
@@ -60,11 +62,11 @@ class SparkConf:
 
     Examples
     --------
-    >>> from pyspark.core.conf import SparkConf
-    >>> from pyspark.core.context import SparkContext
+    >>> from pyspark.conf import SparkConf
+    >>> from pyspark.context import SparkContext

Review Comment:
   The PR title doesn't mention this `SparkContext` change at all. Could you 
proceed `SparkContext` change as a separate PR at least please, @HyukjinKwon ?
   ```
   Make SparkConf to root level to for both SparkSession and SparkContext
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to