panbingkun commented on code in PR #45893:
URL: https://github.com/apache/spark/pull/45893#discussion_r1554551604


##########
connector/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/ConsumerStrategy.scala:
##########
@@ -127,7 +126,7 @@ private[kafka010] case class 
SubscribePatternStrategy(topicPattern: String)
       kafkaParams: ju.Map[String, Object]): Consumer[Array[Byte], Array[Byte]] 
= {
     val updatedKafkaParams = setAuthenticationConfigIfNeeded(kafkaParams)
     val consumer = new KafkaConsumer[Array[Byte], 
Array[Byte]](updatedKafkaParams)
-    consumer.subscribe(ju.regex.Pattern.compile(topicPattern), new 
NoOpConsumerRebalanceListener())

Review Comment:
   After https://github.com/apache/kafka/pull/14638/files
   the class `NoOpConsumerRebalanceListener` has been removed
   
   
https://github.com/apache/kafka/blob/bdd85405e3d72b5089d99026ca1e5aa5b3bc3e51/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L695-L696
   <img width="948" alt="image" 
src="https://github.com/apache/spark/assets/15246973/3bce12b2-e9fd-4f05-8cc6-5d94b0737b05";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to