pan3793 commented on code in PR #2: URL: https://github.com/apache/spark-kubernetes-operator/pull/2#discussion_r1554631127
########## build-tools/helm/spark-kubernetes-operator/crds/sparkapplications.org.apache.spark-v1.yml: ########## @@ -0,0 +1,6947 @@ +# Generated by Fabric8 CRDGenerator, manual edits might get overwritten! Review Comment: if it's easy(without much effort to set up external building tools, especially OS coupled) to generate the constant code, I think we can remove it, just like we did for antlr, grpc in the spark main repo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
