panbingkun commented on code in PR #45923:
URL: https://github.com/apache/spark/pull/45923#discussion_r1555253496
##########
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala:
##########
@@ -231,14 +232,15 @@ private[hive] object SparkSQLCLIDriver extends Logging {
val historyFile = historyDirectory + File.separator + ".hivehistory"
reader.setHistory(new FileHistory(new File(historyFile)))
} else {
- logWarning("WARNING: Directory for Hive history file: " +
historyDirectory +
- " does not exist. History will not be available
during this session.")
+ logWarning(
+ log"WARNING: Directory for Hive history file: ${MDC(HISTORY_DIR,
historyDirectory)}" +
+ log" does not exist. History will not be available during this
session.")
}
} catch {
case e: Exception =>
logWarning("WARNING: Encountered an error while trying to initialize
Hive's " +
- "history file. History will not be available
during this session.")
- logWarning(e.getMessage)
+ "history file. History will not be available
during this session.", e)
Review Comment:
dito
##########
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala:
##########
@@ -249,7 +251,8 @@ private[hive] object SparkSQLCLIDriver extends Logging {
h.flush()
} catch {
case e: IOException =>
- logWarning("WARNING: Failed to write command history file: " +
e.getMessage)
+ logWarning(
+ log"WARNING: Failed to write command history file:
${MDC(ERROR, e.getMessage)}", e)
Review Comment:
dito
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
