gengliangwang commented on code in PR #45904:
URL: https://github.com/apache/spark/pull/45904#discussion_r1556421508
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/CharVarcharUtils.scala:
##########
@@ -74,10 +75,10 @@ object CharVarcharUtils extends Logging with
SparkCharVarcharUtils {
if (SQLConf.get.charVarcharAsString) {
replaceCharVarcharWithString(dt)
} else if (hasCharVarchar(dt)) {
- logWarning("The Spark cast operator does not support char/varchar type
and simply treats" +
- " them as string type. Please use string type directly to avoid
confusion. Otherwise," +
- s" you can set ${SQLConf.LEGACY_CHAR_VARCHAR_AS_STRING.key} to true,
so that Spark treat" +
- s" them as string type as same as Spark 3.0 and earlier")
+ logWarning(log"The Spark cast operator does not support char/varchar
type and simply treats" +
+ log" them as string type. Please use string type directly to avoid
confusion. Otherwise," +
+ log" you can set ${MDC(SQL_CONF_KEY,
SQLConf.LEGACY_CHAR_VARCHAR_AS_STRING.key)} " +
Review Comment:
```suggestion
log" you can set ${MDC(CONFIG,
SQLConf.LEGACY_CHAR_VARCHAR_AS_STRING.key)} " +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
