gene-db commented on code in PR #45826:
URL: https://github.com/apache/spark/pull/45826#discussion_r1556456624


##########
python/pyspark/sql/types.py:
##########
@@ -1468,6 +1475,36 @@ def __eq__(self, other: Any) -> bool:
         return type(self) == type(other)
 
 
+class VariantVal:

Review Comment:
   Added to the documentation.
   
   I think for now, keeping the lightweight `VariantVal` here, and keeping all 
the binary encoding details in `variant_utils.py` seems fine. We can refactor 
later if needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to