hvanhovell commented on code in PR #45701:
URL: https://github.com/apache/spark/pull/45701#discussion_r1557934162
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -131,13 +131,25 @@ import org.apache.spark.util.SparkClassUtils
class Dataset[T] private[sql] (
val sparkSession: SparkSession,
@DeveloperApi val plan: proto.Plan,
- val encoder: Encoder[T])
+ val encoder: Encoder[T],
+ @DeveloperApi carryOverObservationsOpt: Option[Map[String, Observation]] =
None)
Review Comment:
How well does this work with plugins? Now everyone working on the scala
client needs to be aware that they need to carry over this map. I much prefer
that we send back the plan_id of the CollectMetrics node in the
`ObservedMetrics` node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
