chenhao-db commented on code in PR #45805:
URL: https://github.com/apache/spark/pull/45805#discussion_r1558003489
##########
sql/core/src/test/scala/org/apache/spark/sql/VariantSuite.scala:
##########
@@ -298,4 +300,28 @@ class VariantSuite extends QueryTest with
SharedSparkSession {
}
assert(ex.getErrorClass == "DATATYPE_MISMATCH.INVALID_ORDERING_TYPE")
}
+
+ test("variant_explode") {
+ def check(input: String, expected: Seq[Row]): Unit = {
+ withView("v") {
+ Seq(input).toDF("json").createOrReplaceTempView("v")
+ checkAnswer(sql("select pos, key, to_json(value) from v, " +
+ "lateral variant_explode(parse_json(json))"), expected)
+ val expectedOuter = if (expected.isEmpty) Seq(Row(null, null, null))
else expected
+ checkAnswer(sql("select pos, key, to_json(value) from v, " +
+ "lateral variant_explode_outer(parse_json(json))"), expectedOuter)
+ }
+ }
+
+ Seq("true", "false").foreach { codegenEnabled =>
+ withSQLConf(SQLConf.WHOLESTAGE_CODEGEN_ENABLED.key -> codegenEnabled) {
+ check(null, Nil)
+ check("1", Nil)
Review Comment:
As a side note, Snowflake's
[flatten](https://docs.snowflake.com/en/sql-reference/functions/flatten)
returns an empty result set rather than throwing an error if the variant is not
array or struct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
