nikolamand-db commented on code in PR #45816:
URL: https://github.com/apache/spark/pull/45816#discussion_r1559642438
##########
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##########
@@ -424,21 +424,16 @@ public UTF8String toUpperCase() {
if (numBytes == 0) {
return EMPTY_UTF8;
}
-
- byte[] bytes = new byte[numBytes];
- bytes[0] = (byte) Character.toTitleCase(getByte(0));
+ // Optimization - do char level uppercase conversion in case of chars in
ASCII range
for (int i = 0; i < numBytes; i++) {
- byte b = getByte(i);
- if (numBytesForFirstByte(b) != 1) {
- // fallback
- return toUpperCaseSlow();
- }
- int upper = Character.toUpperCase(b);
- if (upper > 127) {
- // fallback
+ if (getByte(i) < 0) {
Review Comment:
It's equivalent but this way is faster. Please check previous
[discussion](https://github.com/apache/spark/pull/45816#discussion_r1551312118).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
