mridulm commented on code in PR #45367:
URL: https://github.com/apache/spark/pull/45367#discussion_r1559712537
##########
core/src/main/scala/org/apache/spark/internal/config/package.scala:
##########
@@ -1014,6 +1014,15 @@ package object config {
.timeConf(TimeUnit.NANOSECONDS)
.createWithDefaultString("1s")
+ private[spark] val
LISTENER_BUS_EVENT_QUEUE_WAIT_FOR_EVENT_DISPATCH_EXIT_ON_STOP =
+
ConfigBuilder("spark.scheduler.listenerbus.eventqueue.waitForEventDispatchExitOnStop")
+ .doc("Whether wait until the dispatch thread exit when stop invoked. " +
+ "This is set to true by default for graceful shutdown of the event
queue, " +
+ "but allow user to configure the behavior if they don't need.")
+ .version("4.0.0")
+ .booleanConf
+ .createWithDefault(true)
Review Comment:
Instead of making this a Boolean, I would suggest setting this as an int
instead - and set default to 0 to preserve existing behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
