panbingkun commented on code in PR #45927:
URL: https://github.com/apache/spark/pull/45927#discussion_r1560341095
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##########
@@ -229,8 +230,8 @@ private[hive] class HiveClientImpl(
case e: Exception if causedByThrift(e) =>
caughtException = e
logWarning(
- "HiveClient got thrift exception, destroying client and retrying "
+
- s"(${retryLimit - numTries} tries remaining)", e)
+ log"HiveClient got thrift exception, destroying client and
retrying " +
+ log"${MDC(RETRY_COUNT, numTries)} times", e)
Review Comment:
Although there is a `slight difference` in the meaning expressed in these
two places, `one` is how many times are `left` and the `other` is how many
times have been `retried`. In order to be consistent with `other parts of
Spark`, adjustments have been made here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
