cloud-fan commented on code in PR #45589:
URL: https://github.com/apache/spark/pull/45589#discussion_r1560376969
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala:
##########
@@ -389,6 +394,16 @@ class V2ExpressionBuilder(e: Expression, isPredicate:
Boolean = false) {
}
}
+ private def generatePredicateWithName(
Review Comment:
one idea: can we update `generateExpressionWithName` to take the target
expression instead of the children? Then we can simply do
```
val children = e.children
...
if (d.dataType == BooleanType && isPredicate) {
new V2Predicate ...
} else {
new GeneralScalarExpression
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
