pan3793 commented on code in PR #46006:
URL: https://github.com/apache/spark/pull/46006#discussion_r1561015660
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala:
##########
@@ -343,26 +343,34 @@ private case class PostgresDialect() extends JdbcDialect
with SQLConfHelper {
}
}
- override def getArrayDimension(
+ override def updateExtraColumnMeta(
conn: Connection,
- tableName: String,
- columnName: String): Option[Int] = {
- val query =
- s"""
- |SELECT pg_attribute.attndims
- |FROM pg_attribute
- | JOIN pg_class ON pg_attribute.attrelid = pg_class.oid
- | JOIN pg_namespace ON pg_class.relnamespace = pg_namespace.oid
- |WHERE pg_class.relname = '$tableName' and pg_attribute.attname =
'$columnName'
- |""".stripMargin
- try {
- Using.resource(conn.createStatement()) { stmt =>
- Using.resource(stmt.executeQuery(query)) { rs =>
- if (rs.next()) Some(rs.getInt(1)) else None
+ rsmd: ResultSetMetaData,
+ columnIdx: Int,
+ metadata: MetadataBuilder): Unit = {
+ rsmd.getColumnType(columnIdx) match {
+ case Types.ARRAY =>
+ val tableName = rsmd.getTableName(columnIdx)
+ val columnName = rsmd.getColumnName(columnIdx)
+ val query =
+ s"""
+ |SELECT pg_attribute.attndims
+ |FROM pg_attribute
+ | JOIN pg_class ON pg_attribute.attrelid = pg_class.oid
+ | JOIN pg_namespace ON pg_class.relnamespace = pg_namespace.oid
+ |WHERE pg_class.relname = '$tableName' and pg_attribute.attname =
'$columnName'
+ |""".stripMargin
+ try {
+ Using.resource(conn.createStatement()) { stmt =>
+ Using.resource(stmt.executeQuery(query)) { rs =>
+ if (rs.next()) metadata.putLong("arrayDimension", rs.getLong(1))
Review Comment:
should metadata properties like "arrayDimension" be pre-defined? like table
properties defined in `org.apache.spark.sql.connector.catalog.TableCatalog`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
