gengliangwang commented on code in PR #45975:
URL: https://github.com/apache/spark/pull/45975#discussion_r1561516760
##########
common/utils/src/test/scala/org/apache/spark/util/StructuredLoggingSuite.scala:
##########
@@ -108,6 +113,18 @@ trait LoggingSuiteBase
}
}
+ test("Logging with MDC(the value is null)") {
+ Seq(
+ (Level.ERROR, () => logError(msgWithMDCValueIsNull)),
+ (Level.WARN, () => logWarning(msgWithMDCValueIsNull)),
+ (Level.INFO, () => logInfo(msgWithMDCValueIsNull))).foreach {
+ case (level, logFunc) =>
+ val logOutput = captureLogOutput(logFunc)
+ println(logOutput)
Review Comment:
let's get rid of println...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
