dongjoon-hyun commented on code in PR #46019:
URL: https://github.com/apache/spark/pull/46019#discussion_r1562814727
##########
core/src/main/scala/org/apache/spark/api/python/WriteInputFormatTestDataGenerator.scala:
##########
@@ -104,6 +105,7 @@ private[python] class WritableToDoubleArrayConverter
extends Converter[Any, Arra
* This object contains method to generate SequenceFile test data and write it
to a
* given directory (probably a temp directory)
*/
+@deprecated("This class will be move to `test`.", "3.5.2")
Review Comment:
@HyukjinKwon . I understand your point. However, this is **exposed** since
Apache Spark 1.1.0. We don't know if there is someone who take advantage of
this API or not. If we say simply `it's a mistake` and remove **exposed**
methods (Apache Spark 1.1.0 ~ 3.5.x) without deprecation, it would be a
violation of Semantic Versioning. We have `MIMA` check to prevent those kind of
weird situation.
> My concern is that we're marking deprecation, and it sounds like we're
admitting those are actually an API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
