ericm-db commented on code in PR #45932:
URL: https://github.com/apache/spark/pull/45932#discussion_r1562819807
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithValueStateTTLSuite.scala:
##########
@@ -399,7 +205,7 @@ class TransformWithValueStateTTLSuite
AddData(inputStream, InputEvent(ttlKey, "get_ttl_value_from_state",
-1)),
AddData(inputStream, InputEvent(noTtlKey, "get_ttl_value_from_state",
-1)),
AdvanceManualClock(1 * 1000),
- CheckNewAnswer(OutputEvent(ttlKey, -1, isTTLValue = true, 61000)),
+ CheckNewAnswer(OutputEvent(ttlKey, 1, isTTLValue = true, 61000)),
Review Comment:
It wasn't incorrect before - I had changed the getTTLValueFromState function
to return the associated value with the TTL for ListState, and had to change it
for ValueState so that the APIs would match.
-1 was the placeholder value for when `isTTLValue=true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
