dongjoon-hyun commented on code in PR #45895: URL: https://github.com/apache/spark/pull/45895#discussion_r1564350531
########## connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroLogicalTypeInitSuite.scala: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.avro + +import org.apache.spark.SparkConf +import org.apache.spark.sql.QueryTest +import org.apache.spark.sql.internal.SQLConf +import org.apache.spark.sql.test.SharedSparkSession +import org.apache.spark.sql.types.DecimalType + +/** + * Test suite for Avro logical type initialization. + * Tests here must run in isolation, otherwise some other test might + * initialize variable and make this test flaky + */ +abstract class AvroLogicalTypeInitSuite + extends QueryTest + with SharedSparkSession { + + test("custom logical type registration test") { + val avroTypeJson = + s""" + |{ + | "type": "record", + | "name": "Entry", + | "fields": [ + | { + | "name": "test_col", + | "type": [ + | "null", + | { + | "type": "long", + | "logicalType": "custom-decimal", + | "precision": 38, + | "scale": 9 + | } + | ], + | "default": null + | } + | ] + |} + | + """.stripMargin + + val df = spark.read.format("avro").option("avroSchema", avroTypeJson).load() + assert(df.schema.fields(0).dataType == DecimalType(38, 9)) + } +} + +class AvroV1LogicalTypeInitSuite extends AvroLogicalTypeInitSuite { Review Comment: Thank you for adding this test coverage. I verified this. ``` [info] AvroV1LogicalTypeInitSuite: [info] - custom logical type registration test *** FAILED *** (1 second, 105 milliseconds) [info] LongType did not equal DecimalType(38, 9) (AvroLogicalTypeInitSuite.scala:60) [info] Analysis: [info] LongType$(precision: -> 38, scale: -> 9) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
